Extending the MTPNC status #4058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaac-dasan
reviewed
Oct 1, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR extends the MultiTenantPodNetworkConfig (MTPNC) CRD to include additional pod-related fields for better tracking and management. The changes add pod metadata to both the specification and status sections of the CRD.
- Adds
PodUIDfield to the MTPNC spec for pod identification - Adds
NodeNamefield to the MTPNC status for tracking pod placement
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crd/multitenancy/manifests/multitenancy.acn.azure.com_multitenantpodnetworkconfigs.yaml | Updates CRD manifest to include new podUID and nodeName fields |
| crd/multitenancy/api/v1alpha1/multitenantpodnetworkconfig.go | Adds PodUID to spec struct and NodeName to status struct |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
crd/multitenancy/manifests/multitenancy.acn.azure.com_multitenantpodnetworkconfigs.yaml
Outdated
Show resolved
Hide resolved
shreyashastantram
force-pushed
the
swiftv2/mtpnc_changes
branch
from
aafb373 to
f7df550
Compare
isaac-dasan
approved these changes
Oct 7, 2025
miguelgoms
approved these changes
Oct 7, 2025
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Co-authored-by: Copilot <[email protected]> Signed-off-by: shreyashastantram <[email protected]>
…antpodnetworkconfigs.yaml Co-authored-by: Copilot <[email protected]> Signed-off-by: shreyashastantram <[email protected]>
shreyashastantram
removed this pull request from the merge queue due to a manual request
shreyashastantram
force-pushed
the
swiftv2/mtpnc_changes
branch
from
f7df550 to
dac3c5d
Compare
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
* Extending the MTPNC status * Adding generated crd * Adding to poduid to Spec * Adding crd changes * Update crd/multitenancy/api/v1alpha1/multitenantpodnetworkconfig.go Co-authored-by: Copilot <[email protected]> Signed-off-by: shreyashastantram <[email protected]> * Update crd/multitenancy/manifests/multitenancy.acn.azure.com_multitenantpodnetworkconfigs.yaml Co-authored-by: Copilot <[email protected]> Signed-off-by: shreyashastantram <[email protected]> --------- Signed-off-by: shreyashastantram <[email protected]> Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR focuses on extending the mtpnc spec and status fields to include the Pod UID in the spec and the Node name in the status.
Pod UID is added to the spec because controllers are aware of the pod’s unique identifier at the time of mtpnc creation.
Node name is added to the status because scheduling decisions do not depend on the node name parameter. The node name becomes available only after the scheduling decision has been made.
If Node name were part of the spec, it would act as an optional input from the creator of the mtpnc. This could lead to inconsistent states—for example, if the creator specifies a node name that differs from the actual node where the pod is scheduled.
Issue Fixed:
Requirements:
Notes: